Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking tests disabled because they were not tested by the CI before #7733

Open
3 tasks done
xmfcx opened this issue Jun 27, 2024 · 1 comment
Open
3 tasks done

Tracking tests disabled because they were not tested by the CI before #7733

xmfcx opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)

Comments

@xmfcx
Copy link
Contributor

xmfcx commented Jun 27, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Main cause:

--ctest-args -L .*" this flag for the colcon-test caused many tests to be ignored by the CI everywhere in Autoware repositories.

This issue attempts to remove that flag and disable and track the tests affected by this flag.

Related:

Sister issue:

Purpose

Make sure every test is actually tested by the CI and keep track of disabled tests.

Possible approaches

Disable the tests, add them to table here and also link this issue in those files in a comment.

Definition of done

  • build-and-test passes when the --ctest-args -L .*" flag is gone.

Table of tracked tests

Honestly I was expecting more tests but this single row is all there was.

@takayuki5168 -san, maybe you may assign someone to fix the smoke test or remove it if you if you think it is not useful.

Link to commented section Package Name Related PR
# Temporary disabled, tracked by:
# https://github.com/autowarefoundation/autoware.universe/issues/7733
# find_package(autoware_testing REQUIRED)
# # smoke test for MPC controller
# add_smoke_test(${PROJECT_NAME} ${CONTROLLER_NODE}_exe
# PARAM_FILENAMES "lateral/mpc.param.yaml longitudinal/pid.param.yaml
#trajectory_follower_node.param.yaml"
# TEST_PARAM_FILENAMES "test_controller_mpc.param.yaml test_controller_pid.param.yaml
#test_vehicle_info.param.yaml test_nearest_search.param.yaml"
# TARGET_INFIX "mpc"
# )
# # smoke test for pure pursuit controller
# add_smoke_test(${PROJECT_NAME} ${CONTROLLER_NODE}_exe
# PARAM_FILENAMES "lateral/pure_pursuit.param.yaml longitudinal/pid.param.yaml
#trajectory_follower_node.param.yaml"
# TEST_PARAM_FILENAMES "test_controller_pure_pursuit.param.yaml test_controller_pid.param.yaml
#test_vehicle_info.param.yaml test_nearest_search.param.yaml"
# TARGET_INFIX "pure_pursuit"
# )
autoware_trajectory_follower_node #7731
Copy link

stale bot commented Aug 27, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
Status: No status
Development

No branches or pull requests

2 participants