Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add autoware_ prefix to the URL of gnss_poser #601

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 21, 2024

Description

This PR is a counterpart of autowarefoundation/autoware.universe#8323 in autoware.universe.
The URL to gnss_poser is revised since the package name will change.
This PR should be merged after merging autowarefoundation/autoware.universe#8323.

Plus, I also wrote a caution that the example in directory-structure doesn't match the actual gnss_poser package.

TODO: Rename class name and file name in gnss_poser in autoware.universe to match the example.

  • gnss_poser_core.cpp/hpp -> gnss_poser_node.cpp/hpp
  • autoware::gnss_poser::GNSSPoser -> autoware::gnss_poser::GNSSPoserNode

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: TaikiYamada4 <[email protected]>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TaikiYamada4 TaikiYamada4 merged commit 3584a68 into autowarefoundation:main Aug 30, 2024
8 of 10 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/gnss_poser/add_autoware_prefix branch August 30, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants