Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parking area scene #163

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

Aysenayilmaz
Copy link
Collaborator

@Aysenayilmaz Aysenayilmaz commented Sep 26, 2024

Description

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Aysenayilmaz Aysenayilmaz self-assigned this Sep 26, 2024
ProjectSettings/ProjectSettings.asset Outdated Show resolved Hide resolved
@mozhoku
Copy link
Collaborator

mozhoku commented Sep 27, 2024

Can't run the parking scene with Random Traffic enabled. It causes errors in the console:
image

This might be caused by the Traffic manager not having any reference to the spawning lanes in the scene:

image

@mozhoku
Copy link
Collaborator

mozhoku commented Sep 30, 2024

  1. Please make vehicle spawn closer to the ground. Update the coordinates in the docs and this script
    image

  2. Cleanup the Parking Area Scene hierarchy. Fix names and remove unnecessary objects from the scene
    image

  3. Please make sure there are no errors with the Random Traffic. Here is errors I've encountered during testing the environment.

  • When starting the scene:
    image
  • When changing vehicle limit with the slider from the UI: (Also gives the error above)
    image

There were no issues with spawning the vehicles from Rviz. 👍

Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
@Aysenayilmaz Aysenayilmaz linked an issue Oct 1, 2024 that may be closed by this pull request
@Aysenayilmaz Aysenayilmaz marked this pull request as draft October 1, 2024 08:11
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
@Aysenayilmaz Aysenayilmaz marked this pull request as ready for review October 1, 2024 09:59
@mozhoku mozhoku added tag:deploy-docs type:bug Software flaws or errors. type:documentation Creating or refining documentation. labels Oct 1, 2024
ProjectSettings/ProjectSettings.asset Outdated Show resolved Hide resolved
@mozhoku mozhoku merged commit b7bf152 into autowarefoundation:main Oct 1, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs type:bug Software flaws or errors. type:documentation Creating or refining documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parking area environment ss2 version not in release
2 participants