Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PoSpace seed derivation #3095

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Change PoSpace seed derivation #3095

merged 2 commits into from
Oct 4, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 3, 2024

Motivation and solution is described on the forum: https://forum.autonomys.xyz/t/change-derivation-of-pospace-seed-and-hdd-compatible-exploit/4438?u=nazar-pc

Code contributor checklist:

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to implement the change described on the forum.

teor2345
teor2345 previously approved these changes Oct 4, 2024
Base automatically changed from subspace-core-primitives-refactoring-part-3 to main October 4, 2024 03:29
@nazar-pc nazar-pc dismissed teor2345’s stale review October 4, 2024 03:29

The base branch was changed.

teor2345
teor2345 previously approved these changes Oct 4, 2024
dariolina
dariolina previously approved these changes Oct 4, 2024
Copy link
Member

@dariolina dariolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment nit

crates/subspace-core-primitives/src/hashes.rs Outdated Show resolved Hide resolved
@nazar-pc nazar-pc dismissed stale reviews from dariolina and teor2345 via 41874fc October 4, 2024 11:42
@nazar-pc nazar-pc disabled auto-merge October 4, 2024 12:30
@nazar-pc nazar-pc merged commit c82252d into main Oct 4, 2024
9 checks passed
@nazar-pc nazar-pc deleted the change-pos-seed-derivation branch October 4, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants