Fast sync changes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 88831de.
nazar-pc
approved these changes
May 29, 2024
| debug!(target: "sync", "Clear block gap."); | ||
|
|
||
| let mut transaction = Transaction::new(); | ||
| transaction.remove(columns::META, meta_keys::BLOCK_GAP); |
There was a problem hiding this comment.
Do you know if there are any side effects in the blockchain besides this gap that we need to be prepared for?
There was a problem hiding this comment.
I know only about common blocks with peers in sync engine cache. It is addressed in the restart_sync method along with Full sync mode toggle. It's not critical and auto-recovers but produces error messages sometimes if not addressed with restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates fast-sync API:
connected_peersmethodclear_block_gapwith removing the gap from DBapply_blockfrom exported API