Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update callback verification in HttpRequest. #769

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Update callback verification in HttpRequest. #769

merged 4 commits into from
Jul 25, 2024

Commits on Jul 18, 2024

  1. Update callback verification in HttpRequest. Callback is a property n… 

    …ot a method of $mockedResponse

Changed the method_exists check to a property_exists check in the HttpRequest class. This adjustment ensures that 'callback' is an accessible property of the object before attempting to invoke it. This change improves code reliability, specifically for the cases where HttpRequest is used in unit tests with mock responses.
    @midnite81
    midnite81 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0779313 View commit details
    Browse the repository at this point in the history

  2. Refactor HttpClientTest and add new test scenario 

    A new test case 'the callback of a mock response is called' was added to further ensure the robustness of the application.
    @midnite81
    midnite81 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7846e1b View commit details
    Browse the repository at this point in the history

  3. Revert formatting

    @midnite81
    midnite81 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0b5b366 View commit details
    Browse the repository at this point in the history

  4. Revert formatting

    @midnite81
    midnite81 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ec2919f View commit details
    Browse the repository at this point in the history