Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update test coverage for tenant domain validation changes #756

Merged
merged 3 commits into from
Jan 11, 2024
Merged

test: Update test coverage for tenant domain validation changes #756

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
133feb1
Update Token.php
ramonschriks Jan 9, 2024
171c667
test(added unit tests for validating tokens with issuer claims -> fal…
Jan 9, 2024
f32478b
Merge branch 'auth0:main' into main
ramonschriks Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions tests/Unit/TokenTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,42 @@ function(): SdkConfiguration {
fn() => TokenGenerator::create(TokenGenerator::TOKEN_LOGOUT, TokenGenerator::ALG_HS256, ['events' => null])
]])->throws(InvalidTokenException::class, InvalidTokenException::MSG_MISSING_EVENTS_CLAIM);

it('fails validating a Logout Token with a mismatch `issuer` claim', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt
): void {
$token = new Token($configuration, $jwt->token, Token::TYPE_LOGOUT_TOKEN);
$token->validate();
})->with(['mocked hs256 access token' => [
function(): SdkConfiguration {
$this->configuration->setDomain('invalid-domain.test');
$this->configuration->setClientId('__test_client_id__');
$this->configuration->setTokenAlgorithm('HS256');
$this->configuration->setClientSecret('__test_client_secret__');
return $this->configuration;
},
fn() => TokenGenerator::create(TokenGenerator::TOKEN_LOGOUT, TokenGenerator::ALG_HS256)
]])->throws(InvalidTokenException::class, sprintf(InvalidTokenException::MSG_MISMATCHED_ISS_CLAIM, "https://invalid-domain.test/", "https://domain.test/"));

it('fails validating a Logout Token with a mismatch `issuer` claim with custom domain', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt
): void {
$token = new Token($configuration, $jwt->token, Token::TYPE_LOGOUT_TOKEN);
$token->validate();
})->with(['mocked hs256 access token' => [
function(): SdkConfiguration {
$this->configuration->setDomain('invalid-domain.test');
$this->configuration->setCustomDomain('invalid-custom-domain.test');
$this->configuration->setClientId('__test_client_id__');
$this->configuration->setTokenAlgorithm('HS256');
$this->configuration->setClientSecret('__test_client_secret__');
return $this->configuration;
},
fn() => TokenGenerator::create(TokenGenerator::TOKEN_LOGOUT, TokenGenerator::ALG_HS256)
]])->throws(InvalidTokenException::class, sprintf(InvalidTokenException::MSG_MISMATCHED_ISS_CLAIM, "https://invalid-domain.test/", "https://domain.test/"));


it('fails validating a Logout Token with a malformed `events` claim', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt
Expand Down Expand Up @@ -338,6 +374,46 @@ function(): SdkConfiguration {
fn() => ['nonce' => '__test_nonce__']
]]);

test('validate() with custom domain as token issuer fails, but succeeds with tenant domain', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt,
array $claims
): void {
$token = new Token($configuration, $jwt->token, Token::TYPE_ID_TOKEN);
expect($token->validate(null, null, ['org_123'], $claims['nonce'], 100))->toEqual($token);
})->with(['mocked data' => [
function(): SdkConfiguration {
$this->configuration->setDomain('domain.test');
$this->configuration->setCustomDomain('not-the-issuer.domain');
$this->configuration->setClientId('__test_client_id__');
$this->configuration->setTokenAlgorithm('HS256');
$this->configuration->setClientSecret('__test_client_secret__');
return $this->configuration;
},
fn() => TokenGenerator::create(TokenGenerator::TOKEN_ID, TokenGenerator::ALG_HS256, ['org_id' => 'org_123']),
fn() => ['nonce' => '__test_nonce__']
]]);

test('validate() with custom domain as token issuer succeeds, tenant domain is thereby irrelevant', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt,
array $claims
): void {
$token = new Token($configuration, $jwt->token, Token::TYPE_ID_TOKEN);
expect($token->validate(null, null, ['org_123'], $claims['nonce'], 100))->toEqual($token);
})->with(['mocked data' => [
function(): SdkConfiguration {
$this->configuration->setDomain('invalid-domain.test');
$this->configuration->setCustomDomain('domain.test');
$this->configuration->setClientId('__test_client_id__');
$this->configuration->setTokenAlgorithm('HS256');
$this->configuration->setClientSecret('__test_client_secret__');
return $this->configuration;
},
fn() => TokenGenerator::create(TokenGenerator::TOKEN_ID, TokenGenerator::ALG_HS256, ['org_id' => 'org_123']),
fn() => ['nonce' => '__test_nonce__']
]]);

test('validate() overrides globally configured algorithm', function(
SdkConfiguration $configuration,
TokenGeneratorResponse $jwt,
Expand Down
Loading