Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added ext-mbstring to composer.json dependencies #730

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: Added ext-mbstring to composer.json dependencies #730

merged 1 commit into from
Sep 25, 2023

Conversation

jasonspriggs
Copy link
Contributor

Changes

Added ext-mbstring to composer.json dependencies. Some systems, such as Heroku, require PHP extension dependencies to be specified in composer.json. This pull request resolves that dependency.

References

auth0/symfony#155 (comment)

Testing

Contributor Checklist

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (d10c4a2) 100.00% compared to head (0a687ec) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #730   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1327      1327           
===========================================
  Files             62        62           
  Lines           4613      4613           
===========================================
  Hits            4613      4613           
Flag Coverage Δ
unittestsvalidate 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims
Copy link
Member

Thanks, @jasonspriggs!

@evansims evansims added this pull request to the merge queue Sep 25, 2023
Merged via the queue into auth0:main with commit d233730 Sep 25, 2023
22 checks passed
@jasonspriggs jasonspriggs deleted the patch-1 branch September 25, 2023 14:45
@evansims evansims mentioned this pull request Oct 18, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2023
### Added

- Support `initiate_login_uri` property for `PATCH` requests to the
`/api/v2/clients/:id` Management API endpoint.
[#732](#732)

### Fixed

- Token generator typo in claim header.
[#729](#729)

### Changed

- `composer.json` now identifies `mbstring` as a required extension.
[#730](#730)
- PHP 8.3 nightlies have been added to the continuous integration
testing matrix. [#733](#733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants