Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in token generator claim #729

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

evansims
Copy link
Member

Changes

This PR fixes a typo in the JSON web token generator class.

References

Closes #728

Contributor Checklist

@evansims evansims added the Scope: Bug Addressing unexpected problems or unintended behavior. label Sep 20, 2023
@evansims evansims linked an issue Sep 20, 2023 that may be closed by this pull request
7 tasks
@evansims evansims temporarily deployed to internal September 20, 2023 21:58 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 21:58 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 21:58 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:19 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:19 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:19 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:24 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:24 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:24 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:33 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:33 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:33 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:36 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:36 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:36 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:39 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:39 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal September 20, 2023 22:39 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6175330) 100.00% compared to head (2768b16) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #729   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1327      1327           
===========================================
  Files             62        62           
  Lines           4613      4613           
===========================================
  Hits            4613      4613           
Flag Coverage Δ
unittestsvalidate 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Token/Generator.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review September 20, 2023 23:33
@evansims evansims requested a review from a team as a code owner September 20, 2023 23:33
@evansims evansims added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit d10c4a2 Sep 21, 2023
23 checks passed
@evansims evansims deleted the fix/jwt-generator-wrong-header-key-type branch September 21, 2023 14:10
@evansims evansims mentioned this pull request Oct 18, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2023
### Added

- Support `initiate_login_uri` property for `PATCH` requests to the
`/api/v2/clients/:id` Management API endpoint.
[#732](#732)

### Fixed

- Token generator typo in claim header.
[#729](#729)

### Changed

- `composer.json` now identifies `mbstring` as a required extension.
[#730](#730)
- PHP 8.3 nightlies have been added to the continuous integration
testing matrix. [#733](#733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Bug Addressing unexpected problems or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT generator: wrong header key "type"
3 participants