Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed release process to use maven publish plugin directly #739

Merged
merged 10 commits into from
May 28, 2024

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented May 27, 2024

Changes

  • Removed usage of oss-gradle-plugin for publishing the package
  • updated gradle files to use maven-publish plugin for publishing
  • updated gradle to version 7.3.3
  • updated release ci actions to use maven publish instead of oss-gradle-plugin
  • updated authentication process with maven central to use token instead of passwords

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@desusai7 desusai7 requested a review from a team as a code owner May 27, 2024 18:43
@desusai7 desusai7 marked this pull request as draft May 27, 2024 18:43
@desusai7 desusai7 self-assigned this May 27, 2024
@desusai7 desusai7 marked this pull request as ready for review May 28, 2024 07:13
@desusai7 desusai7 added review:small Small review and removed F3: in progress labels May 28, 2024
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! nice work @desusai7, I think we just have to make some changes to the release action as we have changed the number of variables we are passing in and the command to do the release has changed now - https://github.com/auth0/Auth0.Android/blob/main/.github/actions/maven-publish/action.yml#L39

Everything looks good to me

@desusai7
Copy link
Contributor Author

This looks great! nice work @desusai7, I think we just have to make some changes to the release action as we have changed the number of variables we are passing in and the command to do the release has changed now - https://github.com/auth0/Auth0.Android/blob/main/.github/actions/maven-publish/action.yml#L39

Everything looks good to me

@poovamraj, updated the maven-publish action with new variables. Can you please take a look again ?

@desusai7 desusai7 requested a review from poovamraj May 28, 2024 09:32
@desusai7 desusai7 merged commit abd641c into main May 28, 2024
9 checks passed
@desusai7 desusai7 deleted the fix/release branch May 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants