Add more error pairs to isMultifactorCodeInvalid [SDK-4194] (#664)

auth0 · Jun 23, 2023 · ef24ca5 · ef24ca5
1 parent ec0625a
commit ef24ca5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/auth0/src/main/java/com/auth0/android/authentication/AuthenticationException.kt b/auth0/src/main/java/com/auth0/android/authentication/AuthenticationException.kt
@@ -157,6 +157,8 @@ public class AuthenticationException : Auth0Exception {
     /// When MFA code sent is invalid or expired
     public val isMultifactorCodeInvalid: Boolean
         get() = "a0.mfa_invalid_code" == code || "invalid_grant" == code && "Invalid otp_code." == description
+                || code == "invalid_grant" && description == "Invalid binding_code."
+                || code == "invalid_grant" && description == "MFA Authorization rejected."
 
     /// When password used for SignUp does not match connection's strength requirements.
     public val isPasswordNotStrongEnough: Boolean

diff --git a/auth0/src/test/java/com/auth0/android/authentication/AuthenticationExceptionTest.kt b/auth0/src/test/java/com/auth0/android/authentication/AuthenticationExceptionTest.kt
@@ -314,6 +314,26 @@ public class AuthenticationExceptionTest {
         MatcherAssert.assertThat(ex.isMultifactorCodeInvalid, CoreMatchers.`is`(true))
     }
 
+    @Test
+    public fun shouldHaveInvalidMultifactorCodeForWrongBindingCode() {
+        values[ERROR_KEY] = "invalid_grant"
+        values[ERROR_DESCRIPTION_KEY] = "Invalid binding_code."
+        val ex = AuthenticationException(
+            values
+        )
+        MatcherAssert.assertThat(ex.isMultifactorCodeInvalid, CoreMatchers.`is`(true))
+    }
+
+    @Test
+    public fun shouldHaveInvalidMultifactorCodeWhenAuthorizationRejected() {
+        values[ERROR_KEY] = "invalid_grant"
+        values[ERROR_DESCRIPTION_KEY] = "MFA Authorization rejected."
+        val ex = AuthenticationException(
+            values
+        )
+        MatcherAssert.assertThat(ex.isMultifactorCodeInvalid, CoreMatchers.`is`(true))
+    }
+
     @Test
     public fun shouldHaveInvalidMultifactorCode() {
         values[CODE_KEY] = "a0.mfa_invalid_code"