Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream class star #1128

Merged
merged 6 commits into from
Feb 8, 2021
Merged

Upstream class star #1128

merged 6 commits into from
Feb 8, 2021

Conversation

Ambrevar
Copy link
Member

@Ambrevar Ambrevar commented Feb 5, 2021

Following up to #1102, I've upstreamed most of the changes brought by our class-star.
In particular, upstream has adopted the class* nickname which means we can no longer use it.

This change set it meant to ease the transition before the library gets updated on Quicklisp.

  1. When Quicklisp updates defclass-star, then we will be able to finalize the package nickname renaming by renaming all the
(hu.dwim.defclass-star:make-name-transformer name)

to

(class*:make-name-transformer name)
  1. One change is still pending upstream: Add support for automatic type inference (enabled by default). hu-dwim/hu.dwim.defclass-star#3. If it gets accepted, then we can safely remove our class-star. If not, then we need to update class-star to apply this one change.

Please check if this works for you.

@aartaka
Copy link
Contributor

aartaka commented Feb 8, 2021

Works for me!

@Ambrevar
Copy link
Member Author

Ambrevar commented Feb 8, 2021 via email

@Ambrevar
Copy link
Member Author

Ambrevar commented Feb 8, 2021 via email

@jmercouris
Copy link
Member

OK to merge, I guess we'll make it less wordy when upstream is done.

@jmercouris jmercouris merged commit 8d243c4 into master Feb 8, 2021
@Ambrevar Ambrevar deleted the upstream-class-star branch July 28, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants