feat: made the Docker file Multistaged #3237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkv24
requested review from
quetzalliwrites,
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee,
asyncapi-bot-eve and
anshgoyalevil
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
asyncapi-bot
requested review from
sambhavgupta0705,
BhaswatiRoy,
J0SAL,
TRohit20 and
VaishnaviNandakumar
hkv24
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3237--asyncapi-website.netlify.app/ |
| ENV NODE_ENV=development | ||
|
|
||
| CMD ["npm", "run", "dev"] | ||
|
|
||
| # Build command -> docker build -f Dockerfile.dev --build-arg NODE_ENV=development -t app-dev . |
There was a problem hiding this comment.
What does this line of code signify?
| @@ -123,14 +123,25 @@ Generated files of the storybook go to the `storybook-static` folder. | |||
| After cloning repository to your local, perform the following steps from the root of the repository. | |||
|
|
|||
| #### Steps: | |||
| 1. Build the Docker image: | |||
| 1. Development Setup with Docker: | |||
| 1. Build the Docker image: | |||
There was a problem hiding this comment.
This is not rendering in a proper way
Check the preview in online md file convertor
| @@ -0,0 +1,31 @@ | |||
| FROM node:18-alpine AS build | |||
There was a problem hiding this comment.
Please provide the link for this code file from where you have taken inspiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing Dockerfile was good for development environment. But in order to build it fast for production environment I made 2 files Dockerfile.dev and Dockerfile.prod .
The production file is taking nearly half the time of development file to build.
I also updated the readme.md file.
Resolves #3223