fix: normalized logos of sponsors #3169
Conversation
Signed-off-by: wck-iipi <[email protected]>
Wck-iipi
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Wck-iipi
changed the title
Wck-iipi
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3169--asyncapi-website.netlify.app/ |
| * @param {string} props.className - Additional CSS class names for styling the image. | ||
| * @param {string} props.dataTestId - A string for identifying the element during testing. | ||
| */ | ||
| const ResponsiveImage: React.FC<ResponsiveImageProps> = ({ src, alt, className, dataTestId }) => { |
There was a problem hiding this comment.
Why to create separate component for Responsive images? We can add this property to component of respective category.
There was a problem hiding this comment.
HDI logo size is way too huge as compared to others, so probably we have to built a component that restricts the logo size with fixed dimension.
I thought that creating a component was required? Do you want me to do this without writing a new component or with?
Signed-off-by: wck-iipi <[email protected]>
Description
Related issue(s)
Fixes #3158