Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hot fixes for build dashboard script not running #3099

Closed
wants to merge 3 commits into from

Conversation

jerensl
Copy link
Contributor

@jerensl jerensl commented Jul 18, 2024

Description
I apologize for not noticing another node-fetch used inside of scripts/dashboard/build-dashboard.js, this commit should fix the issues now regarding node-fetch on the script

Related issue(s)
Fixes #3036

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 66750bc
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66ea9cccb91abe0008c20d5d
😎 Deploy Preview https://deploy-preview-3099--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jul 18, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3099--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

@jerensl can you run it locally and see that if this is working or not?

@jerensl
Copy link
Contributor Author

jerensl commented Jul 22, 2024

@jerensl can you run it locally and see that if this is working or not?

I don't have API for Google Calendar so I cannot test it but as you see before I made the previous PR #3038, we didn't get a response from Newsroom Youtube videos as shown here https://github.com/asyncapi/website/actions/runs/9736154584/job/26866380565, but as now we already got the response and showed another same error in different file https://github.com/asyncapi/website/actions/runs/10032558277/job/27724452766, I'm also checking there no another node-fetch inside scripts folder as well

@sambhavgupta0705
Copy link
Member

closing this one as the issue is now under bounty program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated listing of meetings and other data fails since 2 weeks
3 participants