-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable tools view regeneration on a build time #2264
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2264--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty clean to me, @akshatnema thoughts?
I'm not in support of including the building of tools in build time because if we make these scripts at the build level, tools.json will be updated or regenerated at every start of the website. And we don't have such frequent changes in the tools. So, we can make a workflow such that whenever there will be changes in |
So, We can have a new workflow such that if there are any changes to A few things we have to take into account:
The problem that may occur is that if adding the /do-not-merge script takes more time than expected, then the PR could get merged during that period. Another approach could be:To push the changes into the contributor's PR directly. This could be possible when:
What are your views @akshatnema, @derberg ? |
@asyncapi-bot is working like a charm.😄 |
@akshatnema but building of tools during build just handles manual tools only, quick operation. During build we build also other things, like rss feed, or case studies - that also do not change often. ci/cd automation is nice but the more custom workflows the harder migration is (you could see how long it took to migrate recently) |
Ok, got your point well. But looking into present changes made by @princerajpoot20, I think we should have a separate file for building manual tools at build time. I'm not in preference to change the current build-tools automation because I've a different plan for it (to restructure the implementation of tools generation). Therefore, it would be nice, if we take building of manual tools in separate script file. WDYT? @derberg |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2264--asyncapi-website.netlify.app/ |
@akshatnema really depends. The question is when do you plan these changes. Cause if not soon, then I say we merge as it is and later just refactor. |
@derberg @akshatnema Ping Pong 😅 |
@princerajpoot20 Kindly resolve the conflicts first. |
@princerajpoot20 any update on this issue? |
Done. resolved conflicts. |
@derberg @akshatnema PTAL |
@princerajpoot20 please resolve the conflicts |
Description
regenerate-tools.yml
, the default function,buildTools
, will be used.buildToolsManual
function is used. This function utilizes the currently availabletools-automated.json
, ensuring automated tools don't regenerate with every build. This ensures changes are visible in PR preview.Resolves #2124