Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused import of 'CommonModel' #1538

Merged
merged 1 commit into from
Oct 2, 2023
Merged

chore: remove unused import of 'CommonModel' #1538

merged 1 commit into from
Oct 2, 2023

Conversation

anshttg
Copy link
Contributor

@anshttg anshttg commented Oct 2, 2023

Resolves #1537

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit ab4c853
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/651acc03f22c820008d4ea9d
😎 Deploy Preview https://deploy-preview-1538--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni changed the title fix: remove this unused import of 'CommonModel' chore: remove this unused import of 'CommonModel' Oct 2, 2023
@jonaslagoni jonaslagoni changed the title chore: remove this unused import of 'CommonModel' chore: remove unused import of 'CommonModel' Oct 2, 2023
jonaslagoni
jonaslagoni approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it as chore as it does not directly influence or fix broken code, but cleans it up 🙂

Thanks @pipliya 👍

@jonaslagoni
Copy link
Member

/rtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6381080854

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.239%
Totals Coverage Status
Change from base Build 6020135108: 0.0%
Covered Lines: 5277
Relevant Lines: 5579
💛 - Coveralls

@asyncapi-bot asyncapi-bot merged commit 1bd58bc into asyncapi:master Oct 2, 2023
32 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @pipliya for code

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2023
Merged
@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @pipliya! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove this unused import of 'CommonModel'.
4 participants
@anshttg @jonaslagoni @coveralls @asyncapi-bot