Add a script to regenerate the aia asdf file and do so #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 91.17% 91.26% +0.09%
==========================================
Files 25 25
Lines 1065 1065
==========================================
+ Hits 971 972 +1
+ Misses 94 93 -1 ☔ View full report in Codecov by Sentry. |
Cadair
force-pushed
the
aia_generate
branch
2 times, most recently
from
696b33c
to
d876c6c
Compare
|
It's not clear to me why the data would appear to have changed, but since I can't regenerate the original file I don't know how to see why! |
|
The data hasn't changed though, just the metadata, right? |
|
For the test failure related to the adaptive roundtrip test it looks like the sun rotates a bit between the new result and the reference result Screencast.from.16-07-24.11.10.43.webm |
astrofrog
force-pushed
the
aia_generate
branch
2 times, most recently
from
15b1e26
to
03149f5
Compare
|
@Cadair - hopefully this should work now! Let's see what CI says. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.