Nullable traits and default value (WIP) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (default is None and nullable) or default is not None: | ||
| super(NumericalTrait, self).__init__(default_value=default) | ||
| else: | ||
| super(NumericalTrait, self).__init__() |
There was a problem hiding this comment.
What does the default_value argument default to? Can you have just one super call and adapt the value of default appropriately?
|
The base trait_type has a |
|
@SylvainCorlay right, I was not sure it was part of the public API. I am reimplementing the functionality to take advantage of that. |
…e corresponding traitlets primitives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small extension that enables numtraits to be nullable (i.e.,
Nonecan be assigned to a trait) and to be constructed with a default value.