Always include "Show Logs" button for window messages #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't the complete picture because there's still astral-sh/ruff#12523 (comment) that needs to be solved. |
MichaReiser
approved these changes
Sep 6, 2024
| @@ -454,14 +462,20 @@ export async function startServer( | |||
| break; | |||
| } | |||
| }), | |||
| newLSClient.onNotification(ShowMessageNotification.type, (params) => { | |||
There was a problem hiding this comment.
For my understanding. This doesn't apply to $logTrace? This is only run when the LSP sends an explicit show message request?
I'm asking because I think that showing a dialog for info and warning traces would be a bit overly aggressive.
There was a problem hiding this comment.
Yeah, this doesn't apply to $/logTrace. This only applies to the https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessage request which is what the editor uses to display notifications from the server.
dhruvmanila
added a commit
that referenced
this pull request
Sep 9, 2024
## Summary Ensures that the extension calls `updateStatus` with `busy=false` when the server startup is complete. This is now necessary after #600 correctly added an `updateStatus` call with `busy=true` before the server starts. Fixes #605 ## Test Plan I ran the extension and verified that the busy indicator no longer spins forever. --------- Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes a "Show Logs" button for all window messages from Ruff. This might be useful to reduce the friction for the users in figuring out where the logs are. This is something I saw when looking at koxudaxi/ruff-pycharm-plugin#463 description.
Test Plan