Update to reflect the stabilized ruff server
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/readme
branch
2 times, most recently
from
8a696d8
to
ac08069
Compare
dhruvmanila
changed the title
ruff serverruff server
dhruvmanila
force-pushed
the
dhruv/readme
branch
from
ac08069
to
267f362
Compare
MichaReiser
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
LGTM. Let's wait for @charliermarsh I think he wants to do the final approval.
Should we add a sentence saying that whether ruff-lsp or ruff server is used, can be seen in the toolbar?
Good idea. I'll add a "Troubleshooting" section because I don't think it's present in the toolbar by default. Edit: Added a troubleshooting section in #533 |
dhruvmanila
force-pushed
the
dhruv/readme
branch
from
267f362
to
419204b
Compare
charliermarsh
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the README to reflect the stabilized
ruff server. It also changes the minimum required version for the usage ofruff serverinnativeServer: autoto be0.5.3.For the README, the settings that are just a pass through to the native server are removed and instead we point the users to the online settings reference. Now, the settings table only contains the ones which are specific to VS Code extension.
For review, here's the rendered README: https://github.com/astral-sh/ruff-vscode/blob/dhruv/readme/README.md
resolves: #520