Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameterise clang-tidy aspect #307

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

peakschris
Copy link
Contributor

@peakschris peakschris commented Jul 2, 2024

Parameterize clang-tidy aspect name and mnemonic. We have a custom clang-tidy extension, and with this change we can create an extra aspect that runs it, and also have a default aspect that runs the OOTB clang-tidy.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

@peakschris peakschris marked this pull request as ready for review July 2, 2024 22:40
@peakschris
Copy link
Contributor Author

This is only supported for clang-tidy because I'm not aware of any other linters that can be extended codefully to support new rule checks (but I may be wrong, please let me know). Unless there are use cases to support parameterisation of the other ones, I'd prefer to keep this limited.

@alexeagle
Copy link
Member

Other linters have plugins, eslint for example could have different linter binaries setup with plugins specific to some subfolder of the repo. So the user might need to create more than one eslint aspect. Is that the use case here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants