refactor: change npm_import(is_gnu_tar) to system_tar

[jbedard]

Changes are visible to end-users: no

Test plan

• Covered by existing test cases

[aspect-workflows]

Test

2 test targets passed

Targets

//npm/private:_test_gendocs_0_0 [k8-fastbuild] 221ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild] 228ms

Total test execution time was 449ms. 191 tests (99.0%) were fully cached saving 39s.

---

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 486ms.

---

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 557ms.

---

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

---

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

---

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.

---

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

---

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

---

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

---

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

---

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 251ms.

---

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

---

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

---

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 566ms.

---

Test

e2e/pnpm_lockfiles

All tests were cache hits

28 tests (100.0%) were fully cached saving 10s.

---

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

---

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.

---

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 453ms.

---

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.

---

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

---

Buildifier      Format

[alexeagle]

nit: I think check_* implies no return value and throws if violated. To make the type more intuitive I think it ought to be is_system_tar (or uses_system_tar)

[jbedard]

Good point, another thing we should have done originally.

I've changed it to is_system_tar. I'm not sure if that's the greatest name but at least it implies it returns something related to "system tar".

[gregmagolan]

🦖