chore: add generation file to npm_translate_lock and npm_import #1534
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the fix for #1412 release in v1.39.1 requires the npm_import repository rules to re-run with the fix in-place but just upgrading to rules_js 1.39.1 doesn't invalidate the npm_import repository rules.
This PR adds a generated
_generation
file to npm_import and npm_translate_lock so that on upgrade we can guarantee that these repository rules are re-run to pick up the fix. After this lands I'll cut a 1.39.2.Type of change
Test plan