chore: cleanup WORKSPACE and MODULE.bazel files (#1673)

.bazeliskrc

@@ -1,2 +1,2 @@
 BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
-USE_BAZEL_VERSION=aspect/5.9.24
+USE_BAZEL_VERSION=aspect/5.9.25

.github/workflows/buildifier.yaml

@@ -0,0 +1,20 @@
+name: Buildifier
+
+# Controls when the action will run.
+on:
+    # Triggers the workflow on push or pull request events but only for the main branch
+    push:
+        branches: [main]
+    pull_request:
+        branches: [main]
+
+    # Allows you to run this workflow manually from the Actions tab
+    workflow_dispatch:
+
+jobs:
+    check:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v4
+            - name: buildifier
+              run: bazel run --enable_bzlmod //:buildifier.check

.github/workflows/release_prep.sh

@@ -34,7 +34,7 @@ bazel_dep(name = "aspect_rules_js", version = "${TAG:1}")
 # By default you get the node version from DEFAULT_NODE_VERSION in @rules_nodejs//nodejs:repositories.bzl
 # Optionally you can pin a different node version:
 bazel_dep(name = "rules_nodejs", version = "6.1.0")
-node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
+node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
 node.toolchain(node_version = "16.14.2")
 #################################
 

.gitignore

@@ -5,10 +5,11 @@ node_modules/
 .DS_Store
 .bazelrc.user
 
-# Disable lockfile for now. It is unstable.
+# Don't commit lockfile for now as it is unstable. Do allow for it to be
+# created, however, since it gives a performance boost for local development.
 # https://github.com/bazelbuild/bazel/issues/19026
 # https://github.com/bazelbuild/bazel/issues/19621
 # https://github.com/bazelbuild/bazel/issues/19971
 # https://github.com/bazelbuild/bazel/issues/20272
 # https://github.com/bazelbuild/bazel/issues/20369
-MODULE.bazel.lock
+MODULE.bazel.lock

.pre-commit-config.yaml

@@ -9,19 +9,19 @@ default_stages: [commit]
 repos:
     # Check formatting and lint for starlark code
     - repo: https://github.com/keith/pre-commit-buildifier
-      rev: 6.1.0.1
+      rev: 6.4.0
       hooks:
           - id: buildifier
           - id: buildifier-lint
     # Enforce that commit messages allow for later changelog generation
     - repo: https://github.com/commitizen-tools/commitizen
-      rev: v2.18.0
+      rev: v3.24.0
       hooks:
           # Requires that commitizen is already installed
           - id: commitizen
             stages: [commit-msg]
     - repo: https://github.com/pre-commit/mirrors-prettier
-      rev: 'v2.4.0'
+      rev: v3.1.0
       hooks:
           - id: prettier
     - repo: https://github.com/koalaman/shellcheck-precommit

BUILD.bazel

@@ -5,8 +5,8 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
 load("@buildifier_prebuilt//:rules.bzl", "buildifier")
 load("@npm//:defs.bzl", "npm_link_all_packages", "npm_link_targets")
 load("@pnpm__links//:defs.bzl", npm_link_pnpm = "npm_link_imported_package")
-load("//npm:defs.bzl", "npm_link_package")
 load("//js:defs.bzl", "js_library")
+load("//npm:defs.bzl", "npm_link_package")
 
 # Link all packages from the /WORKSPACE npm_translate_lock(name = "npm") and also packages from
 # manual /WORKSPACE npm_import rules to bazel-bin/node_modules as well as the package store
@@ -99,6 +99,7 @@ buildifier(
     lint_mode = "fix",
     lint_warnings = ["-out-of-order-load"],  # TODO: enable out-of-order-load
     mode = "fix",
+    tags = ["manual"],  # tag as manual so windows ci does not build it by default
 )
 
 buildifier(
@@ -107,6 +108,7 @@ buildifier(
     lint_mode = "warn",
     lint_warnings = ["-out-of-order-load"],  # TODO: enable out-of-order-load
     mode = "diff",
+    tags = ["manual"],  # tag as manual so windows ci does not build it by default
 )
 
 alias(

MODULE.bazel

@@ -9,11 +9,10 @@ module(
 # Lower-bounds (minimum) versions for direct runtime dependencies.
 # Do not bump these unless rules_js requires a newer version to function.
 bazel_dep(name = "aspect_bazel_lib", version = "2.7.1")
-bazel_dep(name = "aspect_rules_lint", version = "0.12.0")
 bazel_dep(name = "bazel_features", version = "1.9.0")
 bazel_dep(name = "bazel_skylib", version = "1.5.0")
-bazel_dep(name = "rules_nodejs", version = "6.1.0")
 bazel_dep(name = "platforms", version = "0.0.5")
+bazel_dep(name = "rules_nodejs", version = "6.1.0")
 
 node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
 use_repo(node, "nodejs_darwin_amd64")
@@ -46,10 +45,12 @@ use_repo(bazel_lib_toolchains, "bsd_tar_toolchains")
 
 ####### Dev dependencies ########
 
-bazel_dep(name = "gazelle", version = "0.35.0", dev_dependency = True, repo_name = "bazel_gazelle")
-bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)
+bazel_dep(name = "aspect_rules_lint", version = "0.12.0", dev_dependency = True)
 bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True)
+bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)
+bazel_dep(name = "gazelle", version = "0.36.0", dev_dependency = True, repo_name = "bazel_gazelle")
 bazel_dep(name = "rules_go", version = "0.46.0", dev_dependency = True)
+bazel_dep(name = "stardoc", version = "0.6.2", dev_dependency = True, repo_name = "io_bazel_stardoc")
 
 host = use_extension(
     "@aspect_bazel_lib//lib:extensions.bzl",

WORKSPACE

@@ -1,7 +1,4 @@
-workspace(
-    # see https://docs.bazel.build/versions/main/skylark/deploying.html#workspace
-    name = "aspect_rules_js",
-)
+workspace(name = "aspect_rules_js")
 
 # buildifier: disable=bzl-visibility
 load("//js/private:dev_deps.bzl", "rules_js_dev_dependencies")
@@ -186,6 +183,28 @@ npm_import(
     version = "8.4.0",
 )
 
+############################################
+# Stardoc
+load("@io_bazel_stardoc//:setup.bzl", "stardoc_repositories")
+
+stardoc_repositories()
+
+load("@rules_jvm_external//:repositories.bzl", "rules_jvm_external_deps")
+
+rules_jvm_external_deps()
+
+load("@rules_jvm_external//:setup.bzl", "rules_jvm_external_setup")
+
+rules_jvm_external_setup()
+
+load("@io_bazel_stardoc//:deps.bzl", "stardoc_external_deps")
+
+stardoc_external_deps()
+
+load("@stardoc_maven//:defs.bzl", stardoc_pinned_maven_install = "pinned_maven_install")
+
+stardoc_pinned_maven_install()
+
 # Buildifier
 load("@buildifier_prebuilt//:deps.bzl", "buildifier_prebuilt_deps")