Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add esbuild transpiler #62

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add esbuild transpiler #62

wants to merge 1 commit into from

Conversation

dzbarsky
Copy link

No description provided.

@dzbarsky dzbarsky mentioned this pull request Aug 29, 2022
Closed
jbedard
jbedard reviewed Aug 29, 2022
View reviewed changes
esbuild/defs.bzl
@@ -62,3 +62,10 @@ def esbuild(name, output_dir = False, splitting = False, config = None, **kwargs
deps = deps,
**kwargs
)

esbuild_transpiler = rule(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets create a macro here similar to the swc one to hide things like js_outs etc: https://github.com/aspect-build/rules_swc/blob/785f94c2bf39d3ddac4cbfd9d7786f6067209f77/swc/defs.bzl

jbedard
jbedard reviewed Aug 29, 2022
View reviewed changes
esbuild/private/esbuild.bzl
if ctx.outputs.map_outs:
action_outputs.append(ctx.outputs.map_outs[i])

ctx.actions.run(
Copy link
Member

@jbedard jbedard Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a mnemonic and progress message, see swc

@jbedard
Copy link
Member

jbedard commented Aug 29, 2022

I think we need things such as:

@cgrindel
Copy link
Contributor

There has not been much activity on this PR. For now, we will convert it to a draft. Please mark as ready for review when you are ready to proceed.

@cgrindel cgrindel marked this pull request as draft October 13, 2022 17:45
@gregmagolan gregmagolan added enhancement New feature or request wip Work-in-progress; not ready for a final review or for landing labels Feb 14, 2023
@alexeagle
Copy link
Member

I think this was fixed in #98

@alexeagle alexeagle closed this Nov 21, 2023
@DavidZbarsky-at
Copy link

DavidZbarsky-at commented Nov 21, 2023 •
edited
Loading

@alexeagle I think there's additional glue needed to plug esbuild into ts_project but it's doable 100% in "userspace" so it's fine to close this out, though its maybe worth having an example in the repo? I'm not sure how common it is to use esbuild as a transpiler

@alexeagle
Copy link
Member

alexeagle commented Nov 21, 2023 •
edited
Loading

I see, would you like to push this one forward then?

@alexeagle alexeagle reopened this Nov 21, 2023
@DavidZbarsky-at
Copy link

Yeah, I have the macro bit Jason mentioned done now, I'll polish it a bit and submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request wip Work-in-progress; not ready for a final review or for landing
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dzbarsky @jbedard @cgrindel @alexeagle @DavidZbarsky-at @gregmagolan