Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not copy cypress binary on macos #55

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: do not copy cypress binary on macos #55

merged 1 commit into from
Nov 3, 2023

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 25, 2023

Fixes #43

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's some reason we must continue to copy it on non-Macos platforms??

@mrmeku
Copy link
Contributor

mrmeku commented Oct 30, 2023

I guess there's some reason we must continue to copy it on non-Macos platforms??

Yeah, directories in a workspace's source tree aren't compatible with RBE. Thus we copy the directory to bazel-out for RBE support.

This change essentially means that RBE will be supported only on linux platforms. I don't love that that's necessary, but I don't see any other way around the mac security prompt

@gregmagolan
Copy link
Member

gregmagolan commented Oct 30, 2023

@mattem recently got RBE working with directories source trees with RBE with our diff_test rule tho I don't remember how he did it

@jbedard jbedard merged commit 07f3b2f into main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: '"Cypress.app" is damaged and can't be opened.' error on mac.
4 participants