chore: various cleanups

- Upgrade e2e version of cypres to 13.6.6
- Run prettier
- Set test timeouts to short
- Disable cypress lifecycle for cypress

.gitignore

@@ -3,6 +3,7 @@ bazel-*
 .idea/
 .ijwb/
 node_modules
+.github/pull_request_template.md
 
 # Don't commit lockfile for now as it is unstable. Do allow for it to be
 # created, however, since it gives a performance boost for local development.

e2e/workspace/MODULE.bazel

@@ -1,13 +1,11 @@
-bazel_dep(name = "aspect_rules_cypress", version = "0.0.0", dev_dependency = True)
+bazel_dep(name = "aspect_rules_cypress")
 local_path_override(
     module_name = "aspect_rules_cypress",
     path = "../..",
 )
-
-cypress = use_extension("@aspect_rules_cypress//cypress:extensions.bzl", "cypress", dev_dependency = True)
-cypress.toolchain(cypress_version = "12.12.0")
+cypress = use_extension("@aspect_rules_cypress//cypress:extensions.bzl", "cypress")
+cypress.toolchain(cypress_version = "13.6.6")
 use_repo(cypress, "cypress_toolchains")
-
 register_toolchains("@cypress_toolchains//:all")
 
 bazel_dep(name = "aspect_rules_js", version = "1.41.2", dev_dependency = True)
@@ -16,6 +14,10 @@ bazel_dep(name = "bazel_features", version = "1.9.0", dev_dependency = True)
 npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)
 npm.npm_translate_lock(
     name = "npm",
+    lifecycle_hooks_exclude = [
+        # Speed up installation by disabling cypress binary install. Optional.
+        "cypress",
+    ],
     pnpm_lock = "//:pnpm-lock.yaml",
     verify_node_modules_ignored = "//:.bazelignore",
 )

e2e/workspace/WORKSPACE.bazel

@@ -22,7 +22,7 @@ load("@aspect_rules_cypress//cypress:repositories.bzl", "cypress_register_toolch
 
 cypress_register_toolchains(
     name = "cypress",
-    cypress_version = "12.12.0",
+    cypress_version = "13.6.6",
 )
 
 load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
@@ -44,6 +44,10 @@ load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
 
 npm_translate_lock(
     name = "npm",
+    lifecycle_hooks_exclude = [
+        # Speed up installation by disabling cypress binary install. Optional.
+        "cypress",
+    ],
     pnpm_lock = "//:pnpm-lock.yaml",
     verify_node_modules_ignored = "//:.bazelignore",
 )

e2e/workspace/cli_test/BUILD

@@ -2,6 +2,7 @@ load("@aspect_rules_cypress//cypress:defs.bzl", "cypress_test")
 
 cypress_test(
     name = "cli_test",
+    timeout = "short",
     args = [
         "run",
         "--config-file=cypress.config.ts",

e2e/workspace/cli_test/cypress.config.ts

@@ -1,13 +1,13 @@
-import { defineConfig } from 'cypress'
+import { defineConfig } from "cypress";
 
 export default defineConfig({
   e2e: {
     specPattern: ["cli_test.cy.ts"],
     supportFile: false,
     setupNodeEvents(on, config) {
-      on('before:browser:launch', (browser, launchOptions) => {
-        launchOptions.args.push("--disable-gpu-shader-disk-cache")
-      })
-    }
+      on("before:browser:launch", (browser, launchOptions) => {
+        launchOptions.args.push("--disable-gpu-shader-disk-cache");
+      });
+    },
   },
-})
+});

e2e/workspace/module_test/BUILD.bazel

@@ -2,6 +2,7 @@ load("@aspect_rules_cypress//cypress:defs.bzl", "cypress_module_test")
 
 cypress_module_test(
     name = "module_test",
+    timeout = "short",
     data = [
         "cypress.config.js",
         "module_test.cy.js",

e2e/workspace/module_test/cypress.config.js

@@ -1,13 +1,13 @@
-const { defineConfig } = require('cypress')
+const { defineConfig } = require("cypress");
 
 module.exports = defineConfig({
   e2e: {
     specPattern: ["*.cy.js"],
     supportFile: false,
-    setupNodeEvents(on, config) {
-      on('before:browser:launch', (browser = {}, launchOptions) => {
-        launchOptions.args.push("--disable-gpu-shader-disk-cache")
-      })
-    }
+    setupNodeEvents(on, _config) {
+      on("before:browser:launch", (_browser, launchOptions) => {
+        launchOptions.args.push("--disable-gpu-shader-disk-cache");
+      });
+    },
   },
-})
+});

e2e/workspace/module_test/runner.js

@@ -12,7 +12,7 @@ async function main() {
     return 1;
   }
 
-  if (result.status !== "finished") {
+  if (result.status === "failed") {
     console.error("Cypress tests failed with status", result.status);
     return 2;
   }

e2e/workspace/package.json

@@ -3,8 +3,8 @@
   "version": "1.0.0",
   "description": "Tests for cypress bazel rules",
   "dependencies": {
-    "cypress": "12.12.0",
+    "cypress": "13.6.6",
     "express": "^4.19.2",
     "typescript": "4.9.5"
   }
-}
+}

e2e/workspace/server_example/BUILD.bazel

@@ -9,6 +9,7 @@ js_binary(
 
 cypress_test(
     name = "server_example",
+    timeout = "short",
     args = [
         "run",
         "--config-file=cypress.config.js",