Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install manpages during Nix installation #1276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hauleth
Copy link

@hauleth hauleth commented Mar 13, 2024

No description provided.

@bryango
Copy link
Contributor

bryango commented Mar 17, 2024

This is no longer necessary as the man page installation has been upstreamed (by me haha), so one can simply update flake.lock and the man pages should get installed automatically.

@hauleth
Copy link
Author

hauleth commented Mar 17, 2024

Yeah, but upstream fix will not fix cases, when I want to use current development tree, as for example when I want to use git branchless submit with GitHub PRs.

@bryango
Copy link
Contributor

bryango commented Mar 17, 2024

The flake.nix here inherits nixpkgs's packaging functions (including postInstall), but builds on top of the current git master:

git-branchless/flake.nix

Lines 18 to 26 in 3faa074

# reuse the definition from nixpkgs git-branchless
git-branchless = prev.git-branchless.overrideAttrs ({ meta, ... }: {
name = "git-branchless";
src = self;
cargoDeps = final.rustPlatform.importCargoLock {
lockFile = ./Cargo.lock;
};

So we should get the best of both worlds. I specifically did this in #1246 to achieve the goal. It should really just work. Otherwise there might be a bug...

@arxanas
Copy link
Owner

arxanas commented May 12, 2024

Is this PR still necessary given the above? I don't use Nix, so I can't tell myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants