Skip to content

Commit

Permalink
build: update MSRV to 1.74
Browse files Browse the repository at this point in the history
It may become difficult to upgrade dependencies in the future.

- I don't want to fall too far behind. Many automatic dependency updates are now failing, indicating that breaking changes are happening upstream that we haven't integrated.
- Since git-branchless is a CLI application, it doesn't have its downstream dependents to worry about breaking.

The specific value is somewhat arbitrary:

- We're just following `clap`'s current MSRV,
  - which aims to trail the latest Rust version by 6-9 months
    - (and the management of `clap`'s MSRV is its entire own topic).
  - My hope is that many applications in the Rust ecosystem also follow the `clap` MSRV and that packagers have worked out the installation strategy for those applications.
  • Loading branch information
arxanas committed Apr 28, 2024
1 parent d08cb78 commit e87ab50
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linux-git-devel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.67.0
toolchain: 1.74
override: true

- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.67.0
toolchain: 1.74
override: true

- name: Cache dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.67.0
toolchain: 1.74
override: true

- name: Cache dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.67.0
toolchain: 1.74
override: true

- name: Cache dependencies
Expand Down
2 changes: 1 addition & 1 deletion .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ image:
file: .gitpod/Dockerfile
tasks:
- init: |
rustup default 1.67.0
rustup default 1.74
cargo test --no-run
cargo install cargo-insta
cargo install git-branchless && git branchless init
Expand Down
2 changes: 1 addition & 1 deletion git-branchless/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = "MIT OR Apache-2.0"
name = "git-branchless"
readme = "../README.md"
repository = "https://github.com/arxanas/git-branchless"
rust-version = "1.67.0"
rust-version = "1.74"
version = "0.8.0"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Expand Down

0 comments on commit e87ab50

Please sign in to comment.