the comma #23
Merged
the comma #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that `;` cannot consistently be used for parameter lists with defaults, so we revert back to using `,` to separate identdefs except when doing so would result in AST inequality - this works for all known cases and returns us to comma-land generally. * fix missing `:` in command post-statements * fix parsing of top-level statements with `;` (nim-lang/Nim#23088) * fix doc-comment support after `=` for vars, consts etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
;cannot consistently be used for parameter lists with defaults, so we revert back to using,to separate identdefs except when doing so would result in AST inequality - this works for all known cases and returns us to comma-land generally.:in command post-statements;(AllowparseAllto parse statements separated by semicolons nim-lang/Nim#23088)=for vars, consts etc