Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64: dts: opi5: make type-c dr_mode host as default #76

Closed
wants to merge 1 commit into from
Closed

arm64: dts: opi5: make type-c dr_mode host as default #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@

&usbdrd_dwc3_0 {
status = "okay";
dr_mode = "otg";
dr_mode = "host";
usb-role-switch;
Comment on lines -364 to 365
Copy link
Member

@hzyitc hzyitc Jul 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usb-role-switch only work with dr_mode = "otg"; ( Not sure )

https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/usb/usb-drd.yaml#L51-L63

You can use the following config:

&usbdrd_dwc3_0 {
	status = "okay";
	dr_mode = "otg";
	usb-role-switch;
	role-switch-default-mode = "host";
};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any way to produce it works/not works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just try to switch mode:

Not sure if the command is correct. My device have some problems now.

echo device >/sys/class/usb_role/usbxxx/role

What's more, you can configure the gadget and test with a male-to-male cable.

Copy link
Member Author

@efectn efectn Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem right i can't assign device role.

I've also tried your way but host didn't work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overlay is fine for who wants to use OTG mode

Copy link
Member

@hzyitc hzyitc Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem right i can't assign device role.

I've also tried your way but host didn't work

What's it mean?

Can't switch or fail to connect to the host device.

I'm not sure if device is corrent. I will test it.

I think overlay is fine for who wants to use OTG mode

It's depend on the maintainers. I just give some suggests.

Copy link
Member Author

@efectn efectn Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzyitc /sys/class/usb_role/fc000000/role is not exists. Howeve, /sys/kernel/debug/usb/fc000000.usb/mode is exists and it prints device if i check it with cat despite i add role-switch-default-mode = "host";

port {
#address-cells = <1>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@
};

&usbdrd_dwc3_0 {
dr_mode = "otg";
dr_mode = "host";
status = "okay";
};

Expand Down
Loading