Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video: rockchip: rga3: fix compatibility with legacy global alpha config #104

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

nyanmisaka
Copy link
Collaborator

Fixes a RGA regression in rkr6 7291693, which broke compatibility with librga 1.9.x and older when using DST over blend/composite and premultiplied alpha.

It's a typo.

req->alpha_config.bg_global_alpha_value = 0xff; // should be `fg` foreground instead of `bg` background
req->alpha_config.bg_global_alpha_value = 0xff; // duplicated

When req_rga->feature.global_alpha_en is false, it means the API version of userspace librga is 1.9.x and older. And this fix is to make sure it falls back to the legacy behavior.

In addition, the source code of librga 1.10 is not yet available to the public at this point.

Fixes a typo in 7291693, which broke compatibility with librga API 1.9.x
and older when using DST over blend/composite and premultiplied alpha.

Signed-off-by: nyanmisaka <[email protected]>
@amazingfate
Copy link
Collaborator

Another rga3 related issue: gstreamer videoconvert can't use RGA3 to convert hdmiin. Here is the pipeline command line I use:

GST_VIDEO_CONVERT_USE_RGA=1 gst-launch-1.0 -e v4l2src device=/dev/video0 ! videoconvert ! waylandsink

After reverting fb4fd88 this pipeline will work again. But I haven't found the root cause.

@nyanmisaka
Copy link
Collaborator Author

Another rga3 related issue: gstreamer videoconvert can't use RGA3 to convert hdmiin. Here is the pipeline command line I use:

GST_VIDEO_CONVERT_USE_RGA=1 gst-launch-1.0 -e v4l2src device=/dev/video0 ! videoconvert ! waylandsink

After reverting fb4fd88 this pipeline will work again. But I haven't found the root cause.

It seems to be related to the use of virt_addr, I don't use it in my FFmpeg build and use dma_fd instead, so I don't encounter this problem. Maybe the maintainer of gstreamer plugin @JeffyCN knows more.

@amazingfate amazingfate merged commit 533b152 into armbian:rk-5.10-rkr6 Oct 20, 2023
1 check passed
@nyanmisaka nyanmisaka deleted the fix-rga3-blend branch October 20, 2023 11:29
catalinii pushed a commit to catalinii/linux-rockchip that referenced this pull request Feb 2, 2024
bill88t pushed a commit to BredOS/linux-rockchip that referenced this pull request Feb 19, 2024
samboudiang pushed a commit to resi-labs/linux-rockchip that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants