Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: rockchip: rk3568: remove opp-supported-hw from gpu_opp_table #103

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

amazingfate
Copy link
Collaborator

Panfrost can't get loaded on rk3568 with rkr6 branch.
Opp tables is not enabled at https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/drivers/opp/of.c#L440-L441.
Since we use panfrost driver so opp-supported-hw is useless, deleting it will make panfrost work.
I also changed gpu interrupt-names and clock-names in rk3568.dtsi for panfrost so work like https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3566-orangepi-3b.dts#L341-L342 is not needed in the future.

@rpardini
Copy link
Member

Tested on rk3566, works:

[   11.556444] panfrost fde60000.gpu: clock rate = 594000000
[   11.556500] panfrost fde60000.gpu: bus_clock rate = 500000000
[   11.556633] panfrost fde60000.gpu: Looking up mali-supply from device tree
[   11.557783] panfrost fde60000.gpu: mali-g52 id 0x7402 major 0x1 minor 0x0 status 0x0
[   11.557834] panfrost fde60000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400
[   11.557845] panfrost fde60000.gpu: Features: L2:0x07110206 Shader:0x00000002 Tiler:0x00000209 Mem:0x1 MMU:0x00002823 AS:0xff JS:0x7
[   11.557853] panfrost fde60000.gpu: shader_present=0x1 l2_present=0x1
[   11.568281] [drm] Initialized panfrost 1.1.0 20180908 for fde60000.gpu on minor 2

@rpardini
Copy link
Member

Tested on rk3568, works

[   13.834461] panfrost fde60000.gpu: clock rate = 594000000
[   13.834630] panfrost fde60000.gpu: bus_clock rate = 500000000
[   13.834808] panfrost fde60000.gpu: Looking up mali-supply from device tree
[   13.837878] panfrost fde60000.gpu: mali-g52 id 0x7402 major 0x1 minor 0x0 status 0x0
[   13.837947] panfrost fde60000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400
[   13.837958] panfrost fde60000.gpu: Features: L2:0x07110206 Shader:0x00000002 Tiler:0x00000209 Mem:0x1 MMU:0x00002823 AS:0xff JS:0x7
[   13.837966] panfrost fde60000.gpu: shader_present=0x1 l2_present=0x1
[   13.840934] [drm] Initialized panfrost 1.1.0 20180908 for fde60000.gpu on minor 2

@neofeo
Copy link

neofeo commented Oct 20, 2023

Many thanks @amazingfate

@amazingfate amazingfate merged commit d974a9f into armbian:rk-5.10-rkr6 Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants