-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MKNOD capability to dockershell container #6927
Add MKNOD capability to dockershell container #6927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Worth noting: this is adding the cap to the |
This doesn't match the code change done. The change affects |
@rpardini it auto defaults to docker on my machine, that's why. |
I can't follow. The PR only changes |
I finally understand what you were talking about. It won't hurt to add that capability to dockershell as well, but I apologize for the misunderstanding on my part. The difficulty of testing is that after a first failed run the |
This reverts commit 8162899. The capability has nothing top do with the actual issue.
This reverts commit 8162899. The capability has nothing top do with the actual issue.
This reverts commit 8162899. The capability has nothing top do with the actual issue.
This reverts commit 8162899. The capability has nothing top do with the actual issue.
This reverts commit 8162899. The capability has nothing top do with the actual issue.
Description
Added arguments
--cap-add MKNOD
todocker run
command to allowlosetup -f
to create the loop device node.Fixes #6568
GitHub issue reference: #6568
Jira reference number AR-2132
How Has This Been Tested?
Running
./compile.sh build BOARD=odroidm1 BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=no KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=bookworm
(auto defaults to build in docker)Checklist:
Please delete options that are not relevant.