Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mt7623: Bump legacy 4.19 to current 6.6 kernel #6902

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

@ColorfulRhino ColorfulRhino commented Jul 7, 2024

Description

The mt7623 family only has one board (BananaPi R2) and has not been properly maintained in many years. Instead of fully removing the family, bump the kernel to 'current' 6.6 since the SoC and also the BananaPi R2 is mainlined and shouldn't cause too many troubles.
No need for 'edge' kernel unless someone plans to step in as maintainer who bumps and tests it on every new kernel release.

Please note: I do not own the hardware. Inspiration for changes were made from this 1.5 years old PR: #4873


By the way, when this is done, there will be no 4.x kernels anymore 🎉
(5.x I'm coming for you soon™ as well 😈)


GitHub issue reference: #6821
Jira reference number AR-2392

How Has This Been Tested?

  • ./compile.sh BOARD=bananapir2 BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=no EXPERT=yes KERNEL_CONFIGURE=no RELEASE=trixie
  • ./compile.sh BOARD=bananapir2 BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=no EXPERT=yes KERNEL_CONFIGURE=no RELEASE=noble

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@ColorfulRhino ColorfulRhino requested a review from a team as a code owner July 7, 2024 12:05
@github-actions github-actions bot added size/large PR with 250 lines or more Framework Framework components Patches Patches related to kernel, U-Boot, ... BSP Board Support Packages labels Jul 7, 2024
@rpardini
Copy link
Member

rpardini commented Jul 7, 2024

Nice. Please, move the main-config.sh change to a separate PR? It's impact is far beyond the bumping of a kernel.

@rpardini
Copy link
Member

rpardini commented Jul 7, 2024

  • Add armhf support to Trixie (was this disabled for a specific reason? If so, please let me know. It builds fine though)

It used to be broken upstream, Igor (AFAIK) disabled it and we forgot?

@rpardini
Copy link
Member

rpardini commented Jul 7, 2024

cpufrequtils: if it is still available on some release, it won't be for long. Suggest this is left alone

@ColorfulRhino
Copy link
Collaborator Author

Nice. Please, move the main-config.sh change to a separate PR? It's impact is far beyond the bumping of a kernel.

Agreed. I have included it in this PR though since the family config needs to make use of it:

declare -g NETWORKING_STACK="systemd-networkd" # Always use systemd-networkd since 'family_tweaks()' includes some network config that currently is only available for networkd; @TODO Change this config to Netplan config

I can add it to a separate PR though no problem 👍

It would be nice to be able to set this after post_family_config hook so that boards can set this variable in their config as well (or can they already? Not sure when board config is loaded), but that didn't work since extension manager is then initialized already.

It used to be broken upstream, Igor (AFAIK) disabled it and we forgot?

Ah I see. I guess it's fine now? At least my image built with Trixie and I couldn't find any package related warnings or errors scrolling through the build log.

cpufrequtils: if it is still available on some release, it won't be for long. Suggest this is left alone

The effect is still the same, cpufrequtils is only removed if release Trixie or Arch riscv. I have only converted the denylist (remove on x) to an allowlist (don't remove on a,b,c,d) in order to allow for easy maintenance (can be left alone for ages, new releases automatically have cpufrequtils removed without needing to change anything).
Is your opinion still the same after the explanation? 😄

NB: This family only has one board (BananaPi R2) and has not been properly maintained in many years, so 'current' LTS kernel is enough.
No need for 'edge' kernel unless someone plans to step in as maintainer who bumps and tests it on every new kernel release.

- Adjust BananaPi R2 board config (board is mainlined)
- Remove legacy kernel patch folder and kernel config
- Remove unstable WiFi stuff
- Move uboot patch dir to v2024.07 since the `legacy` folder is only for vendor or very old uboots.
@github-actions github-actions bot added the Hardware Hardware related like kernel, U-Boot, ... label Jul 7, 2024
@ColorfulRhino
Copy link
Collaborator Author

Nice. Please, move the main-config.sh change to a separate PR? It's impact is far beyond the bumping of a kernel.

Dropped 4 commits from this PR, moved 3 of them over to #6911

Completely dropped cpufrequtils

@ColorfulRhino ColorfulRhino added the Needs review Seeking for review label Jul 8, 2024
config/kernel/linux-mt7623-current.config Outdated Show resolved Hide resolved
This enabled more Mediatek drivers for potential better support for the mt7623 SoC.
@adeepn
Copy link
Member

adeepn commented Jul 9, 2024

build ok. commit and let's go fix this later :)

@ColorfulRhino ColorfulRhino added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release and removed Needs review Seeking for review labels Jul 9, 2024
@adeepn adeepn merged commit de030c7 into armbian:main Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release BSP Board Support Packages Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

3 participants