Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To modify the PWM-fan temperature control policy of fine3399 to adjust the fan speed to a lower level #6843

Merged
merged 18 commits into from
Jul 9, 2024

Conversation

Lemon1151
Copy link
Contributor

@Lemon1151 Lemon1151 commented Jun 30, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

To modify the PWM-fan temperature control policy of fine3399 to adjust the fan speed to a lower level.
Integrating support for xiaobaonas and fine3399 boards into the rockchip64-6.9 kernel

Documentation summary for feature / change

Please delete this section if entry to main documentation is not needed.

If documentation entry is predicted, please provide key elements for further implementation into main documentation and set label to "Needs Documentation". You are welcome to open a PR to documentation or you can leave following information for technical writer:

  • short description (copy / paste of PR title)
  • summary (description relevant for end users)
  • example of usage (how to see this in function)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jun 30, 2024
@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Needs review Seeking for review labels Jun 30, 2024
@EvilOlaf
Copy link
Member

EvilOlaf commented Jul 1, 2024

It might be better to use bare dt instead of patches as in the PRs below:
#6824
#6842

@Lemon1151
Copy link
Contributor Author

It's been a week, why hasn't the review been conducted yet? Could it be that the submitted patch will cause issues with the source code compilation?

@igorpecovnik
Copy link
Member

It's been a week

Our review capacity is very small. We try to get more people on this https://forum.armbian.com/staffapplications/application/23-code-reviewer/ but there is sadly not much interest. Review is hard and inglorious work ... I am open for ideas what else we could try?

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jul 9, 2024
@igorpecovnik igorpecovnik merged commit 41aa99e into armbian:main Jul 9, 2024
9 checks passed
@EvilOlaf
Copy link
Member

I made a comment about concerns but whatever...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

3 participants