Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aic8800 driver for Rock 3C variant #6672

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

Zokhoi
Copy link
Contributor

@Zokhoi Zokhoi commented May 30, 2024

Description

Radxa Rock 3C has a variant with aic8800 wifi 6 module using sdio, marked as board rev 1.4. The dkms driver is added to the image by reusing the extension recently added in #6670.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • dkms builts on current kernel
    ./compile.sh build BOARD=rock-3c BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=yes DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=trixie
    build log: https://paste.armbian.com/epehanekey
  • Wifi is detected on image first boot on my Rock 3C rev 1.4.
  • dkms does not build on edge kernel
    ./compile.sh build BOARD=rock-3c BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=yes DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=trixie
    build logs: https://paste.armbian.com/sucexihale
    dkms make.log: https://paste.armbian.com/okeyuhesom

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@Zokhoi Zokhoi requested a review from igorpecovnik as a code owner May 30, 2024 18:43
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels May 30, 2024
amazingfate
amazingfate previously approved these changes May 31, 2024
@amazingfate
Copy link
Contributor

BTW did you check edge kernel? I wonder if this dkms works for newer mainline kernel.

@Zokhoi
Copy link
Contributor Author

Zokhoi commented May 31, 2024

Seems like the dkms doesn't build for edge kernel.

./compile.sh build BOARD=rock-3c BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=yes DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow RELEASE=trixie
build logs: https://paste.armbian.com/sucexihale
dkms make.log: https://paste.armbian.com/okeyuhesom

@amazingfate
Copy link
Contributor

Since this will break edge's building, it's better to wait for an upstream fix before merge.

@Zokhoi
Copy link
Contributor Author

Zokhoi commented May 31, 2024

Ok, updated top comment.

@chainsx chainsx added the Work in progress Unfinished / work in progress label Jun 2, 2024
@igorpecovnik
Copy link
Member

This ready?

@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels Aug 13, 2024
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested compilation. @Zokhoi Please verify on device.

@igorpecovnik igorpecovnik merged commit d116232 into armbian:main Aug 13, 2024
7 checks passed
@Zokhoi
Copy link
Contributor Author

Zokhoi commented Aug 13, 2024

Both current and edge kernel builds fine. Both images do not detect wifi on first boot, but netplan works and can connect to wifi that way.

@igorpecovnik
Copy link
Member

igorpecovnik commented Aug 13, 2024

Both images do not detect wifi on first boot

Thanks!

This was noticed on some other devices too. We don't know why some works and some don't, while NM detects them properly.

@Zokhoi Zokhoi deleted the rock3c-wifi branch August 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

4 participants