WIP: Lightweight version of ark-circom
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2023
tyshko-rostyslav
changed the title
arc-circomarc-circom
gakonst
requested changes
Feb 8, 2023
Sure, working on it |
tyshko-rostyslav
changed the title
arc-circomark-circom
|
@gakonst Could you, please, take a look? If there are no other issues, could you merge it? |
gakonst
approved these changes
Feb 11, 2023
|
merged + fixed my nits here 746d232 - thank you!! |
|
@gakonst Could you fix the https://github.com/gakonst/ark-circom/blob/746d2329e94e493560a53c41938c329d735d54ed/src/lib.rs#L10 |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR towards #40
As
zerokitis trying to reduce it's binaries' sizes, we'd like a lightweight version ofark-circomto be introduced. That means without the ethers-core/ethers-rs dependencies.vacp2p/zerokit#37