Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from alephium project #1918

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

polarker
Copy link

@polarker polarker commented Mar 15, 2023

Issue / feature description

Hey Argent-X team,



Alephium’s devs here. We would like to express our gratitude for sharing your open source wallet implementation with the space. The quality of the code and the UI/UX design is truly exceptional.

We have successfully forked your wallet to support our own blockchain. While we are unable to merge most of our changes upstream due to the differences in the UTXO model and the sharding logic, we would like to submit a few relevant changes for your review and consideration. Some of these changes are proposals, so please feel free to cherry-pick or modify them as you see fit.



Given our familiarity with your codebase, if there is anything we could help in the future, please don’t hesitate to let us know.



Best regards,

Alephium’s devs


Changes

Minor fixes, updates, and suggestions from Alephium devs

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

export const SESSION_DURATION = isDev ? 24 * 60 * 60 : 30 * 60 // 30 mins in prod, 24 hours in dev
export const SESSION_DURATION = isDev ? 24 * 60 : 30 // 30 mins in prod, 24 hours in dev. Note that the unit is minute, not second
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff, nice thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants