Fix server error in the dashboard when a nested module has a deleted parent #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
fix/dashboard-nested-error
branch
from
7df1da1
to
6b7337c
Compare
Tofandel
force-pushed
the
fix/dashboard-nested-error
branch
from
6b7337c
to
dcaf53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a nested module that you want to show in the dashboard, if you trash a parent without soft deleting the subject, then the dashboard throws an error 500 when it tries to display any activity that happened on one of the children of the deleted parent
Missing required parameter for [Route: twill.articleCategories.articles.edit] [URI: admin/articleCategories/{articleCategory}/articles/{article}/edit] [Missing parameter: article]The error is because the empty parent is ignored and twill tries to use the
moduleRouteas if it was a non nested module route, instead of ignoring the recordThis PR fixes this issue