Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABM corrections #387

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

ABM corrections #387

wants to merge 8 commits into from

Conversation

metric-space
Copy link
Contributor

@metric-space metric-space commented Jul 30, 2024 •
edited
Loading

Fixes

  1. uncaught dataset loader bug that pops up because padding wasn't set correctly

Improves

  1. Use of transpose law to simplify expression
  2. Removes unnecessary complexity and unifies averaging for every weight matrix as opposed to the previous conditional

Testing

Has been tested multiple times with the original (smoke) testing script and alignment has been gauged via cosine angles and frob norms

@metric-space metric-space marked this pull request as draft August 8, 2024 15:49
@metric-space metric-space removed the request for review from thomasgauthier August 26, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metric-space