Specify chat template for output model #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Failed to copy tokenizer. The merge was still successful, just copy it from somewhere else.", | ||
| exc_info=e, | ||
| if tokenizer is None: | ||
| if options.copy_tokenizer: |
cg123
commented
Jul 16, 2024
| if not model_templates: | ||
| return | ||
|
|
||
| chat_template = Counter(model_templates).most_common(1)[0][0] |
There was a problem hiding this comment.
This logic can be made more robust later but this should be good for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
chat_templatefield to merge configs, which can either be a Jinja template string or one ofchatml,llama3,alpaca,mistral. Also supportsautowhich will try to select the most common template among the input models.