Make MultiKeyAuthenicator work #34
Conversation
| BITMAP_NUM_OF_BYTES: int = 4 | ||
| MAX_SIGNATURES: int = 16 |
There was a problem hiding this comment.
I couldn't find this 16 signature limit? Is this just for the SDK?
As far as I can tell, the limit is 255
https://github.com/aptos-labs/aptos-core/blob/main/types/src/transaction/authenticator.rs#L794-L798
There was a problem hiding this comment.
https://github.com/aptos-labs/aptos-core/blob/main/types/src/transaction/authenticator.rs#L811
distinct keys is 16... I think we kinda messed up here, but I think we can make this bigger without any impact since we use the bitvec.
| count = 1 if bitmap < 256 else 2 | ||
| serializer.to_bytes(bitmap.to_bytes(count, "little")) |
There was a problem hiding this comment.
The signature limit accepted on the other side only goes up to 255? https://github.com/aptos-labs/aptos-core/blob/main/types/src/transaction/authenticator.rs#L794-L798
Is there a reason it's doing custom byte sequence serialization? I noticed this is really not simple to do in the Python SDK
There was a problem hiding this comment.
This is how the bitvec works...
length + data
The code was written but never tested... and there was an example test that wasn't being tested either....