[multikey] Add multikey support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add multikey support, and deprecate JSON payloads. They're obsolete with BCS payloads.
davidiw
approved these changes
Aug 20, 2024
gregnazario
force-pushed
the
update-multikey-support
branch
from
01fdcca
to
99673e4
Compare
I'm going to come back with some specs to verify the serialized byte examples. We unfortunately don't really have any / I need to make some |
fishronsage
reviewed
Aug 22, 2024
| data, signature | ||
| ), "Unable to verify signature" | ||
|
|
||
| except Exception: |
There was a problem hiding this comment.
I think we shouldn't catch the exception here, otherwise the assert above will have no effect (don't know what happened)?
There was a problem hiding this comment.
I copied this from MultiEd25519, it's definitely not a great pattern to use. Will follow up with a PR afterwards to move this and MultiEd25519 into a two step process:
- One function to verify the signature and throw exceptions
- One function that wraps it and returns true or false
fishronsage
reviewed
Aug 22, 2024
Co-authored-by: fishronsage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add multikey support, and deprecate JSON payloads. They're obsolete with BCS payloads.
Test Plan
See example
Related Links