-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Add Behave (cucumber) specifications to python #25
Conversation
9a9fc65
to
897f4d9
Compare
897f4d9
to
67894ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine overall
@@ -2,6 +2,10 @@ | |||
|
|||
All notable changes to the Aptos Python SDK will be captured in this file. This changelog is written by hand for now. | |||
|
|||
## Unreleased | |||
- Set max Uleb128 to MAX_U32 | |||
- Add Behave behavioral specifications for BCS and AccountAddress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of features we should call it validator or validation? and maybe add something to our readme or contributors doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder? It's required I think for the behavioral spec framework
162b620
to
d6856b4
Compare
Description
Adds specs from https://github.com/aptos-labs/aptos-sdk-specs and infrastructure for running spec tests
Test Plan
Tested locally, fully succeed
Related Links