Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Add Behave (cucumber) specifications to python #25

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

gregnazario
Copy link
Contributor

Description

Adds specs from https://github.com/aptos-labs/aptos-sdk-specs and infrastructure for running spec tests

Test Plan

Tested locally, fully succeed

Related Links

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine overall

Makefile Show resolved Hide resolved
@@ -2,6 +2,10 @@

All notable changes to the Aptos Python SDK will be captured in this file. This changelog is written by hand for now.

## Unreleased
- Set max Uleb128 to MAX_U32
- Add Behave behavioral specifications for BCS and AccountAddress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of features we should call it validator or validation? and maybe add something to our readme or contributors doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder? It's required I think for the behavioral spec framework

Makefile Show resolved Hide resolved
aptos_sdk/bcs.py Show resolved Hide resolved
@davidiw davidiw enabled auto-merge (squash) August 28, 2024 16:27
@davidiw davidiw merged commit a21e780 into main Aug 28, 2024
8 of 9 checks passed
@davidiw davidiw deleted the add-python-spec branch August 28, 2024 16:30
@gregnazario gregnazario self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants