fix: improve native web tap (strict) and support iOS 15 #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had problem with click on iOs 15. hopefully this PR will fix the problem . |
|
Hi @baselalali, I've just received a report about could not click on iPad landscape mode only from testers. So you could clone this PR and use it in your project. I feel free if you can give me feedback. Thanks. |
|
FYI: I've merged #1361 to configure safari's tab bar position. It probably affects this PR. |
zcmgyu
changed the title
zcmgyu
force-pushed
the
update-native-web-tap
branch
from
2470259
to
39aa01d
Compare
zcmgyu
force-pushed
the
update-native-web-tap
branch
from
39aa01d
to
673afe8
Compare
zcmgyu
force-pushed
the
update-native-web-tap
branch
from
673afe8
to
1493aad
Compare
|
@zcmgyu What do you think about #2071 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore reviewing until I update the description and unit test.
iOS < 15.x or iOS ≥ 15.x but Tab Bar is
Top:iPhone PORTRAIT:
NORMAL, with NOTCH:
x = 0y = availHeight - innerHeight - 3 (OFFSET WITH ACTUAL) - 49 (FIXED BOTTOM) - 30 (FIXED INDICATOR)NORMAL, without NOTCH:
x = 0y = availHeight - innerHeight + 1 (OFFSET WITH ACTUAL) - 44 (FIXED BOTTOM)COLLAPSED, all devices:
x = 0y = availHeight - innerHeight + 1 (OFFSET WITH ACTUAL)iOS < 15.x:
iPhone LANDSCAPE:
NORMAL, with NOTCH:
x = (availWidth - innerWidth) / 2y = availHeight - innerHeight + 1 (OFFSET WITH ACTUAL)NORMAL, without NOTCH:
x = 0y = availHeight - innerHeight + 1 (OFFSET WITH ACTUAL)COLLAPSED, with NOTCH:
x = (availWidth - innerWidth) / 2y = 0COLLAPSED, without NOTCH:
x = 0y = 0iPad PORTRAIT & LANDSCAPE, NORMAL & COLLAPSED:
x = 0y = availHeight - innerHeight + 1 (OFFSET WITH ACTUAL)iOS ≥ 15.x
iPhone PORTRAIT, NORMAL & COLLAPSED
with NOTCH:
x = 0y = 47 (FIXED TOP)without NOTCH:
x = 0y = 20 (FIXED TOP (status bar))iPhone LANDSCAPE
NORMAL, with NOTCH:
x = (availWidth - innerWidth) / 2y = 48 (FIXED TOP)COLLAPSED, with NOTCH:
x = (availWidth - innerWidth) / 2y = 0NORMAL, without NOTCH:
x = 0y = 60 (FIXED TOP)COLLAPSED, without NOTCH:
x = 0y = 0iPad PORTRAIT & LANDSCAPE, NORMAL & COLLAPSED:
x = 0y = availHeight - innerHeightHow to recognize the top bar collapsed or not?