code sandbox deploy preview 🐛 fix #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2dd75c6:
|
…-explorer when built locally? very confusing
mayakoneval
force-pushed
the
maya/fix-code-sandbox-setup
branch
from
b24bba2
to
2dd75c6
Compare
mayakoneval
requested review from
cheapsteak and
trevorblades
and removed request for
trevorblades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am confused because according to this comment and what we have seen in playing around debugging npm publishes before, the built cjs / esm files are built prefixed with
explorerwhen you pull them down from npm, but when built locally they are prefixed withembeddable-explorer?Test by clicking on the code sandbox deploy preview below and see that it all works!