-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue with framework generation #19
Conversation
I updated the script to test it out with carthage.
It appears it's building each scheme twice again because the shared scheme has the same name as scheme Xcode generates for the targets from the swift package. Would it be possible to rename the schemes tuist generates so they are unique? Maybe adding the suffix |
Hmmm ok, wondering if I create the xcode schemes manually in the tuist configuration and disable the auto-generation if it would avoid the issue with the spm package schemes, ill give that a shot and see, odd that |
Actually no that wont work at least for the duplication, but doing the schemes manually and adjusting the names as you suggested seems like a good solution. |
Oops, I should have included the logs, it builds every target twice.
|
I also just noticed that the target for |
@CraigSiemens ok i updated the branch tuist now generates the schemes with a suffix like you suggested and the make commands are all working so I'm guessing this will solve your Carthage issue as well. As for |
That change seems to be working, each target was built once.
|
Great, can get this merged into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixing an issue where the
make
command for building the apollo-ios framework was failing, also fixing issue with carthage not being able to find shared schemes to build from.Closes apollographql/apollo-ios#3439
Closes apollographql/apollo-ios#3427