-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]OSPP Support Kubernetes ConfigMap for Apollo java, golang client #5233
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation for the Java SDK user guide has been updated to include new information about ConfigMap caching in Kubernetes environments for versions 2.4.0 and above. It outlines how clients can cache configuration data from the server within a ConfigMap, enhancing availability during service outages. New configuration properties have been introduced to manage this feature, and the documentation specifies the structure of cached data and the necessary permissions for client pods. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
docs/zh/client/java-sdk-user-guide.md (1)
430-430
: TODO: Add the guide for setting read/write permissions.Please remember to add the guide for setting the necessary read/write permissions for the client pod to access the ConfigMap, as mentioned in the placeholder comment.
Do you want me to open a GitHub issue to track this task?
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/zh/client/java-sdk-user-guide.md (2 hunks)
Additional context used
Markdownlint
docs/zh/client/java-sdk-user-guide.md
409-409: null
No empty links(MD042, no-empty-links)
Additional comments not posted (4)
docs/zh/client/java-sdk-user-guide.md (4)
403-431
: Great addition to enhance availability in Kubernetes environments!The new feature to cache configurations in a ConfigMap is a valuable addition to enhance the availability of the Apollo client in Kubernetes environments. The documentation clearly explains the purpose, configuration properties, and structure of the cached data.
Tools
Markdownlint
409-409: null
No empty links(MD042, no-empty-links)
403-403
: Useful new configuration property for flexibility!The new
apollo.override-system-properties
configuration property in version 2.1.0+ is a helpful addition to provide flexibility in controlling whether Apollo's remote properties should override Java's system properties. The documentation clearly explains its purpose and the order of precedence for configuration.
407-407
: Helpful new configuration property for gray releases!The new
apollo.label
configuration property is a useful addition to allow specifying the label information for the application, which is important for configuring gray release rules. The documentation clearly explains its purpose and the order of precedence for configuration.
Line range hint
453-453
: Excellent support for Spring Boot 2.4+ and WebClient extension!The addition of Config Data Loader support for Spring Boot 2.4+ and Apollo Client 1.9.0+, along with the ability to extend the HTTP client using WebClient, is a great enhancement. The documentation provides clear instructions on the required dependencies, configuration properties, and the extensibility point for customizing the WebClient through an SPI implementation.
What's the purpose of this PR
docs for pr apolloconfig/apollo-java#79
discussion #5210
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
[✅] Read the Contributing Guide before making this pull request.
[✅] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[✅] Write necessary unit tests to verify the code.
[❌] Run mvn clean test to make sure this pull request doesn't break anything.
[❌] Update the CHANGES log.
Summary by CodeRabbit
New Features
Documentation